Zhou Zheng Sheng has posted comments on this change.
Change subject: Fix vdsm_hooks pep8.
......................................................................
Patch Set 1: Verified; I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm_hooks/qos/before_vm_start.py
Line 27: inbound or outbound elements can be once but not mandatory
Line 28:
Line 29: syntax:
Line 30: 00:11:22:33:44:55=in{'average':'1','peek':'2','burst':'5'}^'''
Line 31: '''out{'average':'1'}&11:11:11:11:11:11=...'''
Wrapping the line here does not improve readability. I think we can make the
string shorter by using "MAC1", "MAC2" in the syntax, and add an explanation.
MAC1=in{'average':'1','peek':'2','burst':'5'}^out{'average':'1'}&MAC2=...
Please replace 'MACn' with the MAC address of the virtual nic to be edited.
Line 32:
Line 33: keys = ['average', 'peek', 'burst']
Line 34:
Line 35:
--
To view, visit http://gerrit.ovirt.org/10777
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida004331709ac573db4ae6bf77da407830b31ac8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
