Federico Simoncelli has posted comments on this change. Change subject: udev: Race fix- load and trigger dev rule(#891300) ......................................................................
Patch Set 3: (3 inline comments) .................................................... Commit Message Line 3: AuthorDate: 2013-01-08 12:37:07 +0200 Line 4: Commit: Vered Volansky <[email protected]> Line 5: CommitDate: 2013-01-09 17:01:31 +0200 Line 6: Line 7: udev: Race fix- load and trigger dev rule(#891300) Can you remove the bug citation from here. Bug-Url is enough. Line 8: Line 9: The rule file is generated, yet not synch-loaded in memory, so a VM with Line 10: a with a direct lun fails to start. Line 11: This patch inroduces two additional private udev functions: .................................................... File vdsm/storage/hsm.py Line 2924: Warning: Internal use only. Line 2925: """ Line 2926: supervdsm.getProxy().appropriateDevice(guid, thiefId) Line 2927: supervdsm.getProxy().udevTrigger(guid) Line 2928: try: Ayal suggested a loop here waiting for fileUtils.validateQemuReadable to succeed (with the same timeout you already used). Maybe you could use "retry" from utils.py. This means that we can get rid of udevadm settle. Line 2929: devPath = '/dev/mapper/%s' % guid Line 2930: fileUtils.validateQemuReadable(devPath) Line 2931: except OSError: Line 2932: self.log.error("Failed to appropriate device permission") Line 2925: """ Line 2926: supervdsm.getProxy().appropriateDevice(guid, thiefId) Line 2927: supervdsm.getProxy().udevTrigger(guid) Line 2928: try: Line 2929: devPath = '/dev/mapper/%s' % guid Use DMPATH_FORMAT devicemapper.py Line 2930: fileUtils.validateQemuReadable(devPath) Line 2931: except OSError: Line 2932: self.log.error("Failed to appropriate device permission") Line 2933: raise -- To view, visit http://gerrit.ovirt.org/10758 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3b2008a3d9df2dcaf54190721c2dd9764338627 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Lee Yarwood <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
