Alon Bar-Lev has posted comments on this change.
Change subject: Searching for both py and pyc file to start super vdsm
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/supervdsm.py
Line 43: # path of supervdsmServer
Line 44: for serverFile in ("supervdsmServer.py", "supervdsmServer.pyc"):
Line 45: serverPath = os.path.join(base, serverFile)
Line 46: if os.path.exists(serverPath):
Line 47: return os.path.abspath(serverPath)
Can I ask hy do we need this?
It looks like very bad practice to relay on py or pyc...
In python3 it is something totally different.
Line 48:
Line 49: raise RuntimeError("SuperVDSM Server not found")
Line 50:
Line 51: PIDFILE = os.path.join(constants.P_VDSM_RUN, "svdsm.pid")
--
To view, visit http://gerrit.ovirt.org/10854
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I36771ce46f5d00ad8befe33569252bdb8cffeaa1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
