Dan Kenigsberg has posted comments on this change. Change subject: tests: Fix parted_utils_tests break on fedora 18 ......................................................................
Patch Set 2: I would prefer that you didn't submit this (1 inline comment) .................................................... File tests/parted_utils_tests.py Line 41: PART_END_SIZE = 47 * ONE_MB_IN_BYTES Line 42: Line 43: # parted 3.1 improves its support for loopback devices. The 'model' string Line 44: # returned by libparted is updated to 'Loopback device' Line 45: parted_version = float(putils.parted.version()['libparted']) Would you use distutils.version.StrictVersion instead of float? floats have bad reputation about precision and about handling 3.0.1 bugfix version. Line 46: if parted_version >= 3.1: Line 47: LOOP_DEVICE_MODEL = 'Loopback device' Line 48: else: Line 49: LOOP_DEVICE_MODEL = '' -- To view, visit http://gerrit.ovirt.org/10843 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1accc7eb6fc6c64b5e27fb27d9e675ad523725b0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
