Vinzenz Feenstra has posted comments on this change.
Change subject: Expose a new argument for tunnelled migration of a VM
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm_api/vdsmapi-schema.json
Line 5362: # @file migration use @VM.hibernate.
Line 5363: #
Line 5364: # @method:
Line 5365: #
Line 5366: # @tunnelled: #optional use libvirt's runnelled migration. default
it False.
I think we should start adding @since 4.10.4 in the description if something
was added later. Otherwise it's not clear from the docs that this is different
from 4.10.1 for example
Line 5367: #
Line 5368: # Since: 4.10.0
Line 5369: ##
Line 5370: {'type': 'MigrateParams',
--
To view, visit http://gerrit.ovirt.org/2551
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id713b455db4f9bf437720b64c92bba9377cd89ae
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
