Adam Litke has posted comments on this change. Change subject: Refactor communication infra ......................................................................
Patch Set 15: I would prefer that you didn't submit this (1 inline comment) I may have found a bug. Please check out the comment. .................................................... File vdsm_api/jsonrpc/tcpReactor.py Line 45: if (len(self._sendData) > 0): Line 46: data = self._sendData[0] Line 47: bsent = self._conn.send(data) Line 48: if bsent < len(data): Line 49: self._sendData[0] = data[:bsent] I might very well be wrong, but shouldn't this be: self._sendData[0] = data[bsent:] The way you have it written, it looks like you will just keep the part of the data you already sent. Line 50: else: Line 51: self._sendData.pop(0) Line 52: except (OSError, IOError) as e: Line 53: if e.errno not in (errno.EINTR, errno.EAGAIN): -- To view, visit http://gerrit.ovirt.org/9986 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a65364824cc8433263ccf6ed44f1f97141eff2c Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
