Dan Kenigsberg has posted comments on this change.
Change subject: udev: Race fix- load and trigger dev rule
......................................................................
Patch Set 10: Looks good to me, approved
(1 inline comment)
I cannot say that I love this - udevadm stuff should go to their own new
module, with its proper unit tests. I'll nag Vered about it instead of blocking.
....................................................
File vdsm/supervdsmServer.py
Line 323: cmd = [EXT_UDEVADM, '--version']
Line 324: rc, out, err = misc.execCmd(cmd, sudo=False)
Line 325: if rc:
Line 326: self.log.error("Udevadm version command failed rc=%s, "
Line 327: " out=\"%s\", err=\"%s\"", rc, out, err)
double space
Line 328: raise RuntimeError("Could not get udev version number")
Line 329: return int(out[0])
Line 330:
Line 331: def __udevOperationReload(self):
--
To view, visit http://gerrit.ovirt.org/10758
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3b2008a3d9df2dcaf54190721c2dd9764338627
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Haim Ateya <[email protected]>
Gerrit-Reviewer: Lee Yarwood <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
