Federico Simoncelli has posted comments on this change.
Change subject: seboolsetup: catch RuntimeError expection
......................................................................
Patch Set 1:
I'm not sure I understand/like this logic:
except RuntimeError, e:
if selinux.is_selinux_enabled() == 1:
raise e
This wouldn't raise an error if selinux is disabled, as if we allow that. If we
want to avoid issues during the rpm installation we can use "|| :" in the spec
file, but filtering errors here it doesn't look right.
--
To view, visit http://gerrit.ovirt.org/10892
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I538b028259f81a792eab88e9a281cbd81aad0312
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
