Antoni Segura Puimedon has posted comments on this change.
Change subject: Don't crash on libvirt network re-definition.
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/configNetwork.py
Line 212: if netName not in conn.listNetworks():
Line 213: raise
Line 214: net = conn.networkLookupByName(netName)
Line 215: if bridged:
Line 216: if net.bridgeName() != network:
You're right Mark. This is the conclusion I arrived to during the weekend. I'm
thinking about having netinfo networks add another key _brokenNets where nets
that have broken underlying parts will be put, and then setupNetworks will
remove those.
Line 217: raise
Line 218: else:
Line 219: if parseString(net.XMLDesc(0)).\
Line 220: getElementsByTagName('interface')[0].\
--
To view, visit http://gerrit.ovirt.org/10901
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I76d95e20b7aa99280e604abdb1663c6c5c7dd32e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
