Vinzenz Feenstra has posted comments on this change.
Change subject: Basic AMQP 1.0 transport support
......................................................................
Patch Set 19: (1 inline comment)
....................................................
File tests/jsonRpcTests.py
Line 147: rawSize = self.sock.recv(tcpReactor._Size.size)
Line 148: size = tcpReactor._Size.unpack(rawSize)[0]
Line 149: buff = ""
Line 150: while (size - len(buff)) > 0:
Line 151: buff += self.sock.recv(size)
Do you really want these reallocations?
Why not like this?
buff = []
while (size - len(buff)) > 0:
buff += [self.sock.recv(size)]
return "".join(buff)
Line 152:
Line 153: return buff
Line 154:
Line 155: def close(self):
--
To view, visit http://gerrit.ovirt.org/9987
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I850005e7375472bbf6238fd38b10d8f1b5e2a191
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
