Federico Simoncelli has posted comments on this change.
Change subject: use qemu-img convert to copy sparse volumes when moving a vm
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
It's a -1 just for minor comments. Next round is a +2 for me.
....................................................
File vdsm/storage/image.py
Line 583: # Do the actual copy
Line 584: try:
Line 585: dstVol = destDom.produceVolume(imgUUID=imgUUID,
volUUID=srcVol.volUUID)
Line 586: srcFmt = srcVol.getFormat()
Line 587: if srcFmt == volume.RAW_FORMAT:
Extra space. It doesn't ease the readability.
Line 588: srcFmt = volume.fmt2str(srcFmt)
Line 589: dstFmt = volume.fmt2str(dstVol.getFormat())
Line 590: self.log.debug("start qemu convert")
Line 591: qemuImg.convert(srcVol.getVolumePath(),
Line 584: try:
Line 585: dstVol = destDom.produceVolume(imgUUID=imgUUID,
volUUID=srcVol.volUUID)
Line 586: srcFmt = srcVol.getFormat()
Line 587: if srcFmt == volume.RAW_FORMAT:
Line 588: srcFmt = volume.fmt2str(srcFmt)
I don't like to overwrite variables values. Let's use something different maybe
srcFmtStr and dstFmtStr.
Line 589: dstFmt = volume.fmt2str(dstVol.getFormat())
Line 590: self.log.debug("start qemu convert")
Line 591: qemuImg.convert(srcVol.getVolumePath(),
Line 592: dstVol.getVolumePath(),
--
To view, visit http://gerrit.ovirt.org/10979
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9eedaa41a64502e548e52c10742335abd05301d8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
