Bala.FA has posted comments on this change.
Change subject: Added gluster hooks support for existing hooks
......................................................................
Patch Set 7: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/gluster/cli.py
Line 920: path = os.path.join(_glusterHooksPath, gCmd,
hookLevel.lower())
Line 921: for hookFile in os.listdir(path):
Line 922: status = getattr(HookStatus, hookFile[0], None)
Line 923: if status:
Line 924: hooks.append({'name': os.path.basename(hookFile),
why not hostFile[1:]?
Line 925: 'status': status,
Line 926: 'command': gCmd,
Line 927: 'level': hookLevel,
Line 928: 'md5sum':
_getScriptMd5(os.path.join(path,
--
To view, visit http://gerrit.ovirt.org/9671
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3918aa035d90967f1297dc7fadcf14b6a9385c45
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Bala.FA <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Timothy Asir <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
