Juan Hernandez has posted comments on this change. Change subject: Explicitly shutdown m2crypto socket ......................................................................
Patch Set 1: (1 inline comment) .................................................... Commit Message Line 5: CommitDate: 2013-01-14 10:33:04 +0100 Line 6: Line 7: Explicitly shutdown m2crypto socket Line 8: Line 9: Aparently some versions of the m2crypto library don't shutdown correctly All I know is that Andrey had this problem in CentOS. I can't reproduce it en Fedora, so I guess there is a difference between the m2crypto in Fedora and the m2crypto in CentOS, but I can't tell for sure. When Andrey told me about this issue he told me that the versions that he was using in CentOS are the following (Andrey, correct me if I am wrong): openssl - 1.0.0-25.el6_3.1 python - 2.6.6-29.el6_3.3 m2crypto - 0.20.2-9.el6 In Fedora I used: openssl - 1.0.0j-2.fc17.x86_64 python - 2.7.3-7.2.fc17.x86_64 m2crypto - 0.21.1-8.fc17.x86_64 One of the changes between that versions of m2crytpo is that the Fedora version was updated to upstream 0.21.1, and that upstream version includes a change that could be relevant. As described in the m2crypto CHANGES: - 0.20 started releasing Python locks even around some operations that interacted with the Python runtime, potentially causing crashes and other weirdness, fix by Miloslav Trmac The problem could well be out of m2crypto, but in openssl, or python. I am not sure, still need to test it. Line 10: underlying sockets when a SSL connection is closed. This patch changes Line 11: the SSLSocket class so that it explicitly shuts down and closes the Line 12: underlying socket when when the connection is closed. Line 13: -- To view, visit http://gerrit.ovirt.org/10972 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1a471aaccb32554b94340ebfb92b9d7ba14407a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Andrey Gordeev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
