Zhou Zheng Sheng has posted comments on this change. Change subject: tests/functional: Add GlusterSD functional test ......................................................................
Patch Set 6: Looks good to me, but someone else must approve (1 inline comment) Try to run your code. glusterfs 3.3 and 3.2 didn't work. The latest glusterfs 3.4 qa release works. I think we should bump the gluster version needed by vdsm-gluster. # rpm -qa | grep gluster glusterfs-server-3.4.0qa6-1.el6.x86_64 glusterfs-3.4.0qa6-1.el6.x86_64 glusterfs-fuse-3.4.0qa6-1.el6.x86_64 At the same time, I see some selinux violations when running the test. All are related the glusterfs but not vdsm. I use audit2allow to open some holes on my policies to get the code run. .................................................... File tests/functional/xmlrpcTests.py Line 524: Line 525: class GlusterFSServer(BackendServer): Line 526: def __init__(self, vdsmServer, asserts): Line 527: self.s = vdsmServer Line 528: self.asserts = asserts The above two lines can be replaced by super(GlusterFSServer, self).__init__(vdsmServer, asserts) Line 529: Line 530: # Check if gluster service is operational Line 531: self.glusterVolInfo = self.s.glusterVolumesList() Line 532: if self.glusterVolInfo['status']['code'] != 0: -- To view, visit http://gerrit.ovirt.org/10196 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe27b138d78e0922a6455e0984813823a98aeb53 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Deepak C Shetty <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
