Vinzenz Feenstra has posted comments on this change.

Change subject: vdsm: Refactoring libvirtvm & vm
......................................................................


Patch Set 1: (4 inline comments)

....................................................
File Makefile.am
Line 87:        vdsm/storage/taskManager.py \
Line 88:        vdsm/storage/threadLocal.py \
Line 89:        vdsm/storage/volume.py \
Line 90:        vdsm/vdsm \
Line 91:        vdsm/vm/*.py \
Done
Line 92:        vdsm/vm/devices/*.py \
Line 93:        vdsm/vm/migration/*.py \
Line 94:        vdsm_api \
Line 95:        vdsm_cli \


Line 104: PEP8_BLACKLIST = apiData.py,config.py,constants.py
Line 105: 
Line 106: check-local:
Line 107:       find . -path './.git' -prune -type f -o \
Line 108:               -name '*.py' -o -name '*.py.in'  | xargs $(PYFLAKES)
This is irrelevant to this patch set
Line 109:       $(PEP8) --exclude="$(PEP8_BLACKLIST)" --filename '*.py,*.py.in' 
\
Line 110:               $(PEP8_WHITELIST)
Line 111:       @if test -f .gitignore; then \
Line 112:         for i in `git ls-files \*.in`; do \


....................................................
File vdsm/Makefile.am
Line 58:        vm/migration/__init__.py  \
Line 59:        vm/migration/downtime_thread.py \
Line 60:        vm/migration/monitor_thread.py  \
Line 61:        vm/migration/source_thread.py \
Line 62:        vm/notifying_domain.py  \
Done
Line 63:        vm/stats_thread.py  \
Line 64:        vm/vm.py \
Line 65:        vmChannels.py \
Line 66:        zombieReaper.py \


....................................................
File vdsm.spec.in
Line 645: %{_datadir}/%{vdsm_name}/vm/migration/downtime_thread.py*
Line 646: %{_datadir}/%{vdsm_name}/vm/migration/monitor_thread.py*
Line 647: %{_datadir}/%{vdsm_name}/vm/migration/source_thread.py*
Line 648: %{_datadir}/%{vdsm_name}/vm/notifying_domain.py*
Line 649: %{_datadir}/%{vdsm_name}/vm/stats_thread.py*
Done
Line 650: %{_datadir}/%{vdsm_name}/vm/vm.py*
Line 651: %{_datadir}/%{vdsm_name}/vmChannels.py*
Line 652: %{_datadir}/%{vdsm_name}/write-net-config
Line 653: %{_datadir}/%{vdsm_name}/zombieReaper.py*


--
To view, visit http://gerrit.ovirt.org/10861
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I653be8e06431f1033416aa55d6cb81b4262ba6b1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to