Zhou Zheng Sheng has posted comments on this change. Change subject: vdsm: Simplify device map initialization ......................................................................
Patch Set 2: Looks good to me, but someone else must approve (1 inline comment) .................................................... File vdsm/vm/devices/__init__.py Line 68: "Drive", Line 69: "BalloonDevice", Line 70: "WatchdogDevice", Line 71: "SmartCardDevice", Line 72: "RedirDevice", Should initDeviceMap be added to the __all__ list as well? -- To view, visit http://gerrit.ovirt.org/10867 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I36b89a0aec6fc1311aba2b9213ee4dc705f43e7e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
