Michal Skrivanek has posted comments on this change.
Change subject: dump the core of a VM
......................................................................
Patch Set 10: Looks good to me, but someone else must approve
(2 inline comments)
....................................................
File vdsm/API.py
Line 283:
Line 284: dumpParams.update(params)
Line 285: exclusiveParams = ("live", "crash", "reset")
Line 286: if [dumpParams[x] for x in exclusiveParams].count(True) > 1:
Line 287: msgstr = "'reset', 'crash', and 'live' are mutually
exclusive."
why is the "core dump failed" prefix not here, considering line 279
Line 288: self.log.debug("Core dump failed. " + msgstr)
Line 289: return reportError(msg=msgstr)
Line 290:
Line 291: v = self._cif.vmContainer.get(self._UUID)
....................................................
File vdsm_cli/vdsClient.py
Line 2416: 'coreDump': (serv.coreDump,
Line 2417: ('<vmId> <file> [live=<True|False>] '
Line 2418: '[crash=<True|False>]
[bypass-cache=<True|False>] '
Line 2419: '[reset=<True|False>]
[memory-only=<True|False>]',
Line 2420: "get memeory dump or migration file"
typo. Also you should mention the mutual exclusivity
Line 2421: 'optional params:',
Line 2422: 'crash: crash the domain after core
dump'
Line 2423: 'default False',
Line 2424: 'live: perform a live core dump if
supported, '
--
To view, visit http://gerrit.ovirt.org/7329
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If4aac9e747dc7aa64a6ff5ef256a7a4375aa2bb5
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
