Shu Ming has posted comments on this change.
Change subject: add a jsonrpcSeverClient for jsonRPC Server functional test
......................................................................
Patch Set 2: (4 inline comments)
....................................................
Commit Message
Line 8:
Line 9: This jsonrpcSeverClient is easy to call the jsonRPC server.
Line 10: And it is an example for user to call the jsonRPC server.
Line 11:
Line 12: The jsonrpcSeverClient will parser the vdsmapi-schema.json.
parser-->parse
Line 13: It will generate the method of vdsm-api dynamically.
Line 14:
Line 15: Then we can call the vdsm-api easily, refer to vdsm-api.html.
Line 16: vdsm-api.html is in the vdsm doc path.
Line 9: This jsonrpcSeverClient is easy to call the jsonRPC server.
Line 10: And it is an example for user to call the jsonRPC server.
Line 11:
Line 12: The jsonrpcSeverClient will parser the vdsmapi-schema.json.
Line 13: It will generate the method of vdsm-api dynamically.
I am not sure who will generate the method of the vdsm-api. The jsonrpcServer?
Line 14:
Line 15: Then we can call the vdsm-api easily, refer to vdsm-api.html.
Line 16: vdsm-api.html is in the vdsm doc path.
Line 17:
Line 12: The jsonrpcSeverClient will parser the vdsmapi-schema.json.
Line 13: It will generate the method of vdsm-api dynamically.
Line 14:
Line 15: Then we can call the vdsm-api easily, refer to vdsm-api.html.
Line 16: vdsm-api.html is in the vdsm doc path.
Where does vdsm-api.html come from? Does it exist before the
jsonrpcServerClient is running?
Line 17:
Line 18: Some comments tell us how to call the vdsm-api at the end of
Line 19: jsonrpcSeverClient.py
Line 20:
....................................................
File tests/functional/jsonrpcSeverClient.py
Line 150: # test the RpcClient
Line 151: # you can open vdsm-api.html by your browser, such as by firefox
Line 152: # firefox /usr/share/doc/vdsm-*/vdsm-api.html
Line 153: # vdsm-api.html is in the vdsm doc path.
Line 154: # then can call the API show in vdsm-api.html as follow
Do you mean others can subclass jsonRpcServerClient and re-implement their own
json RPc client if it is necessary?
Line 155: print rpcIns.call("Host.getAllTasksInfo")
--
To view, visit http://gerrit.ovirt.org/11283
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib081e26203638114d7d632489432a50eeea45dd4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Deepak C Shetty <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
