Allon Mureinik has posted comments on this change. Change subject: misc: rename safelease to clusterlock ......................................................................
Patch Set 4: Looks good to me, but someone else must approve (2 inline comments) see annoying inline comment on Makefile.am .................................................... File vdsm/storage/Makefile.am Line 22: Line 23: vdsmstoragedir = $(vdsmdir)/storage Line 24: dist_vdsmstorage_PYTHON = \ Line 25: __init__.py \ Line 26: blockSD.py \ clusterlock.py should go here Line 27: blockVolume.py \ Line 28: devicemapper.py \ Line 29: dispatcher.py \ Line 30: domainMonitor.py \ Line 47: persistentDict.py \ Line 48: remoteFileHandler.py \ Line 49: resourceFactories.py \ Line 50: resourceManager.py \ Line 51: clusterlock.py \ Let's keep this list alphabetized - this is not the right place for clusterlock.py Line 52: sdc.py \ Line 53: sd.py \ Line 54: securable.py \ Line 55: sp.py \ -- To view, visit http://gerrit.ovirt.org/10067 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74070ebb43dd726362900a0746c08b2ee3d6eac7 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
