Zhou Zheng Sheng has posted comments on this change. Change subject: vdsm.spec: increase policycoreutils version for RHEL ......................................................................
Patch Set 1: (2 inline comments) .................................................... File vdsm.spec.in Line 110: Requires: kernel >= 2.6.32-279.9.1 Line 111: Requires: sanlock >= 2.3-4, sanlock-python Line 112: Requires: initscripts >= 9.03.31-2.el6_3.1 Line 113: Requires: mom >= 0.3.0 Line 114: Requires: policycoreutils >= 2.0.83-19.30 ./vdsm/vdsmd.init.in and ./vdsm/vdsm-gencerts.sh invoke /sbin/restorecon which is in policycoreutils . So it's OK we require policycoreutils. When A is required by B, and if we are depend on both A and B, we should require both of them in the spec file. Otherwise, when someone update the code and it does not require B any more and removes the requirement of B in the spec, after that we lose the implicit requirement of A in the spec, but the code continues to use the modules in A. Relying on implicit dependency in the spec while explicit dependency existing in the code is error prone. Line 115: Requires: policycoreutils-python >= 2.0.83-19.30 Line 116: Requires: selinux-policy-targeted >= 3.7.19-155 Line 117: Requires: lvm2 >= 2.02.95-10.el6_3.2 Line 118: Requires: logrotate < 3.8.0 Line 128: Requires: e2fsprogs >= 1.41.14 Line 129: Requires: kernel >= 3.6 Line 130: Requires: mom >= 0.3.0 Line 131: Requires: sanlock >= 2.4-2, sanlock-python Line 132: Requires: policycoreutils-python What if the user just happened to remove policycoreutils-python ? Some packages are installed by default in Fedora and RHEL, but if we are porting VDSM to another non-RH-based distro, or to a custom distro, or someone decide to make a very small distro just enough to run VDSM, the requirements in the spec will be very helpful. Line 133: Requires: sed >= 4.2.1-10 Line 134: Requires: selinux-policy-targeted >= 3.10.0-149 Line 135: Requires: lvm2 >= 2.02.95 Line 136: %endif -- To view, visit http://gerrit.ovirt.org/11341 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2b40781e4e6bba28ac5ebcf54ff089bad09e36d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
