Dan Kenigsberg has posted comments on this change.
Change subject: Fix test errors on el6
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Any reason not to move the assertRaises() redefinition from TestconfigNetwork
to TestCaseBase ?
The context manager syntax is cool, and we already have the code for it for 2.6.
....................................................
File tests/jsonRpcTests.py
Line 250: with constructServer(reactorType, bridge) as (server,
clientFactory):
Line 251: client = clientFactory()
Line 252: client.connect()
Line 253: with closing(client):
Line 254: try:
Toni's implementation for assertRaises is portable, too.
Line 255: client.callMethod("I.DO.NOT.EXIST :(", [], 10)
Line 256: self.fail("Exception expected")
Line 257: except JsonRpcError, ex:
Line 258: self.assertEquals(ex.code,
--
To view, visit http://gerrit.ovirt.org/11350
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I92e1f6a9c8931982b2467ca4b69a6ec819eb0d16
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
