Saggi Mizrahi has uploaded a new change for review. Change subject: jsonrpc: Change start_listening to createListener ......................................................................
jsonrpc: Change start_listening to createListener Change-Id: I846926002d86b5f195dd5ef06aa6039e2e2a0482 Signed-off-by: Saggi Mizrahi <smizr...@redhat.com> --- M tests/jsonRpcTests.py M vdsm_api/BindingJsonRpc.py M vdsm_api/jsonrpc/protonReactor.py M vdsm_api/jsonrpc/tcpReactor.py 4 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/01/11401/1 diff --git a/tests/jsonRpcTests.py b/tests/jsonRpcTests.py index cf47048..180914d 100644 --- a/tests/jsonRpcTests.py +++ b/tests/jsonRpcTests.py @@ -119,7 +119,7 @@ t = threading.Thread(target=reactor.process_requests) t.setDaemon(True) t.start() - reactor.start_listening(laddr) + reactor.createListener(laddr) t = threading.Thread(target=server.serve_requests) t.setDaemon(True) @@ -277,7 +277,7 @@ t = threading.Thread(target=serve, args=(reactor,)) t.setDaemon(True) t.start() - reactor.start_listening(laddr) + reactor.createListener(laddr) clientNum = 1 repeats = 1 diff --git a/vdsm_api/BindingJsonRpc.py b/vdsm_api/BindingJsonRpc.py index 11738c5..a4c6d81 100644 --- a/vdsm_api/BindingJsonRpc.py +++ b/vdsm_api/BindingJsonRpc.py @@ -62,12 +62,12 @@ except KeyError: raise ValueError("cfg") - return self._reactors["tcp"].start_listening((address, port)) + return self._reactors["tcp"].createListener((address, port)) def _createProtonListener(self, cfg): address = cfg.get("host", "0.0.0.0") port = cfg.get("port", 5672) - return self._reactors["amqp"].start_listening((address, port)) + return self._reactors["amqp"].createListener((address, port)) def _createTcpReactor(self): return TCPReactor(self.server) diff --git a/vdsm_api/jsonrpc/protonReactor.py b/vdsm_api/jsonrpc/protonReactor.py index 7b561e7..da903e5 100644 --- a/vdsm_api/jsonrpc/protonReactor.py +++ b/vdsm_api/jsonrpc/protonReactor.py @@ -364,7 +364,7 @@ proton.pn_delivery_set_context(delivery, time.time()) proton.pn_link_advance(link) - def start_listening(self, address): + def createListener(self, address): host, port = address l = self._scheduleOp(True, proton.pn_listener, self._driver, host, str(port), None) diff --git a/vdsm_api/jsonrpc/tcpReactor.py b/vdsm_api/jsonrpc/tcpReactor.py index 2ef8766..bda9057 100644 --- a/vdsm_api/jsonrpc/tcpReactor.py +++ b/vdsm_api/jsonrpc/tcpReactor.py @@ -118,7 +118,7 @@ # TODO: Close on exec self._listeners = {} - def start_listening(self, address): + def createListener(self, address): l = TCPListener(address) self._listeners[address] = l -- To view, visit http://gerrit.ovirt.org/11401 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I846926002d86b5f195dd5ef06aa6039e2e2a0482 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <smizr...@redhat.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches