Dan Kenigsberg has posted comments on this change. Change subject: shareVolumeRollback() unique call likes to raise on the unexpected. ......................................................................
Patch Set 1: I would prefer that you didn't submit this Thanks for dropping these evil try-except blocks. But wouldn't this cause surprise changes to recovery semantics? The short poetry of the commit message does not assure me that this has been considered. Please provide more insight on why this would not break task rollback in new forms. -- To view, visit http://gerrit.ovirt.org/11422 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f01ff2d30ffecc05b9cfd4978f79003a8032270 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
