Hello Ayal Baron, Timothy Asir, Saggi Mizrahi, Federico Simoncelli, Dan
Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/11445
to review the following change.
Change subject: sos: include /var/log/core files
......................................................................
sos: include /var/log/core files
Currently sosreport contains list of files of /var/log/core. There is
a feature request https://bugzilla.redhat.com/show_bug.cgi?id=880952
wants to include all file contents under /var/log/core.
Change-Id: I68b00673b149d1e6adf9c295357de33f32dcd386
Signed-off-by: Bala.FA <[email protected]>
---
M vdsm/sos/vdsm.py.in
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/45/11445/1
diff --git a/vdsm/sos/vdsm.py.in b/vdsm/sos/vdsm.py.in
index d7b9651..29a54c7 100644
--- a/vdsm/sos/vdsm.py.in
+++ b/vdsm/sos/vdsm.py.in
@@ -80,7 +80,7 @@
self.addCopySpec("/proc/%s/cmdline" % pid)
self.addCopySpec("/proc/%s/status" % pid)
self.addCopySpec("/proc/%s/mountstats" % pid)
- self.collectExtOutput("/bin/ls -l /var/log/core")
+ self.addCopySpec("/var/log/core/*")
self.collectExtOutput(
"/bin/su vdsm -s /bin/sh -c '/usr/bin/tree @VDSMREPO@'")
self.collectExtOutput(
--
To view, visit http://gerrit.ovirt.org/11445
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I68b00673b149d1e6adf9c295357de33f32dcd386
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Timothy Asir <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
