Dan Kenigsberg has posted comments on this change.
Change subject: Handle spaces in device names using lvm filter
......................................................................
Patch Set 7: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File tests/lvmTests.py
Line 30: devs = []
Line 31: dev = 'a'
Line 32: for c in chars:
Line 33: dev += '\\' + hex(ord(c))[1:4]
Line 34: devs.append(dev)
this seems as an over-complicated way to write a constant list with one string
element. but I can live with this.
Line 35: filter = lvm._buildFilter(devs)
Line 36: expectedFilter = ("filter = "
Line 37: "[
\'a%a\\\\x20\\\\x24\\\\x7c\\\\x22\\\\x28%\',"
Line 38: " \'r%.*%\' ]"
--
To view, visit http://gerrit.ovirt.org/9191
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1efb6dfd30c0999f14c413fff778213b247a178f
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
