Saggi Mizrahi has posted comments on this change. Change subject: Storage: Check that underlying file system supports direct IO ......................................................................
Patch Set 6: (1 inline comment) .................................................... File vdsm/storage/localFsSD.py Line 36: if os.path.abspath(typeSpecificArg) != typeSpecificArg: Line 37: raise se.StorageDomainIllegalRemotePath(typeSpecificArg) Line 38: Line 39: fileSD.validateDirAccess(domPath) Line 40: fileSD.validateFileSystemFeatures(sdUUID, domPath) No, it will fail as it will not be able to acquire the lock or write the metadata Line 41: Line 42: sd.validateDomainVersion(version) Line 43: Line 44: # Make sure there are no remnants of other domain -- To view, visit http://gerrit.ovirt.org/9749 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf14d1c4737a88e693e5bebb896aef382b8b424c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: humble devassy <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
