Lee Yarwood has posted comments on this change.
Change subject: upgrade: catch MetaDataKeyNotFoundError when preparing images
......................................................................
Patch Set 3: Verified; Looks good to me, but someone else must approve
Verified, we now catch and continue past blanked out metadata.
Thread-786::INFO::2013-01-28 16:43:43,438::logUtils::37::dispatcher::(wrapper)
Run and protect:
upgradeStoragePool(spUUID='5f5b38da-69b2-11e2-8d4a-001a4a210859',
targetDomVersion='3')
[..]
Thread-786::DEBUG::2013-01-28
16:44:06,472::formatConverter::243::Storage.v3DomainConverter::(v3DomainConverter)
Converting image: f9ff166b-3559-4b30-adb4-56eea7c62425
[..]
Thread-786::ERROR::2013-01-28
16:44:06,786::formatConverter::283::Storage.v3DomainConverter::(v3DomainConverter)
It is not possible to prepare the image f9ff166b-3559-4b30-adb4-56eea7c62425,
the volume metadata looks damaged
Traceback (most recent call last):
File "/usr/share/vdsm/storage/imageRepository/formatConverter.py", line 268,
in v3DomainConverter
for vol in img.prepare(domain.sdUUID, imgUUID):
File "/usr/share/vdsm/storage/image.py", line 364, in prepare
chain = self.getChain(sdUUID, imgUUID, volUUID)
File "/usr/share/vdsm/storage/image.py", line 319, in getChain
if len(uuidlist) == 1 and srcVol.isShared():
File "/usr/share/vdsm/storage/volume.py", line 662, in isShared
return self.getVolType() == type2name(SHARED_VOL)
File "/usr/share/vdsm/storage/volume.py", line 623, in getVolType
self.voltype = self.getMetaParam(VOLTYPE)
File "/usr/share/vdsm/storage/volume.py", line 867, in getMetaParam
raise se.MetaDataKeyNotFoundError(str(meta) + ":" + str(key))
MetaDataKeyNotFoundError: Meta Data key not found error: ('{}:VOLTYPE',)
[..]
Thread-786::DEBUG::2013-01-28
16:44:07,121::formatConverter::291::Storage.v3DomainConverter::(v3DomainConverter)
Unable to teardown the image f9ff166b-3559-4b30-adb4-56eea7c62425, this error
is not critical since the volume might be in use
Traceback (most recent call last):
File "/usr/share/vdsm/storage/imageRepository/formatConverter.py", line 287,
in v3DomainConverter
img.teardown(domain.sdUUID, imgUUID)
File "/usr/share/vdsm/storage/image.py", line 379, in teardown
chain = self.getChain(sdUUID, imgUUID, volUUID)
File "/usr/share/vdsm/storage/image.py", line 319, in getChain
if len(uuidlist) == 1 and srcVol.isShared():
File "/usr/share/vdsm/storage/volume.py", line 662, in isShared
return self.getVolType() == type2name(SHARED_VOL)
File "/usr/share/vdsm/storage/volume.py", line 623, in getVolType
self.voltype = self.getMetaParam(VOLTYPE)
File "/usr/share/vdsm/storage/volume.py", line 867, in getMetaParam
raise se.MetaDataKeyNotFoundError(str(meta) + ":" + str(key))
MetaDataKeyNotFoundError: Meta Data key not found error: ('{}:VOLTYPE',)
[..]
Thread-786::DEBUG::2013-01-28
16:44:10,203::formatConverter::295::Storage.v3DomainConverter::(v3DomainConverter)
Finalizing the storage domain upgrade from version 2 to version 3 for domain
dd2e9e56-b962-402b-a316-710037de7a2c
--
To view, visit http://gerrit.ovirt.org/11281
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I92f7a61bf6d1e24e84711486fd4f8ba67e2a0077
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Lee Yarwood <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
