Ayal Baron has posted comments on this change. Change subject: Add forceLink() which replaces a link if it already exists. ......................................................................
Patch Set 2: I would prefer that you didn't submit this (4 inline comments) .................................................... Commit Message Line 3: AuthorDate: 2013-01-27 13:15:49 +0200 Line 4: Commit: Eduardo Warszawski <[email protected]> Line 5: CommitDate: 2013-01-28 10:33:40 +0200 Line 6: Line 7: Add forceLink() which replaces a link if it already exists. it's still raceful... Line 8: Line 9: Reduce the number of fileUtils.safeUnlink() callers. Line 10: Line 11: Change-Id: Idea4ab66cc2954fdb11606daa4a73ad3edb0c7ef Line 5: CommitDate: 2013-01-28 10:33:40 +0200 Line 6: Line 7: Add forceLink() which replaces a link if it already exists. Line 8: Line 9: Reduce the number of fileUtils.safeUnlink() callers. why? Line 10: Line 11: Change-Id: Idea4ab66cc2954fdb11606daa4a73ad3edb0c7ef .................................................... File vdsm/storage/fileVolume.py Line 26: Line 27: from misc import deprecated Line 28: from sdc import sdCache Line 29: from threadLocal import vars Line 30: import storage_exception as se I don't understand your ordering logic here. Line 31: import outOfProcess as oop Line 32: import volume Line 33: import image Line 34: import sd .................................................... File vdsm/utils.py Line 71: exc_info=True) Line 72: raise Line 73: Line 74: Line 75: def forceLink(src, dst): why isn't this in fileUtils? Line 76: """ Makes or replaces a hard link. Line 77: Line 78: Like os.link() but replaces the link if it exists. Line 79: """ -- To view, visit http://gerrit.ovirt.org/11423 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idea4ab66cc2954fdb11606daa4a73ad3edb0c7ef Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
