Ayal Baron has posted comments on this change. Change subject: Do not fail when getVSize is called on an inactive LV. ......................................................................
Patch Set 3: (1 inline comment) .................................................... File vdsm/storage/blockVolume.py Line 94: @classmethod Line 95: def getVSize(cls, sdobj, imgUUID, volUUID, bs=512): Line 96: """ Returns size in block units. Line 97: Line 98: Returns the largest integer value less than or equal to size [blocks]. why less than? it should be rounded up. Line 99: """ Line 100: try: Line 101: size = _tellEnd(lvm.lvPath(sdobj.sdUUID, volUUID)) / bs Line 102: except IOError as e: -- To view, visit http://gerrit.ovirt.org/9739 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a8b6da4d57cdf810769586c1959989d7a545d0c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Daniel Paikov <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Haim Ateya <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
