Ayal Baron has posted comments on this change. Change subject: Adding VM based locks to ovf modify functions. ......................................................................
Patch Set 3: I would prefer that you didn't submit this (2 inline comments) .................................................... File vdsm/storage/hsm.py Line 1250: if sdUUID and sdUUID != sd.BLANK_UUID: Line 1251: pool.validatePoolSD(sdUUID) Line 1252: self.validateSdUUID(sdUUID) Line 1253: else: Line 1254: pool.masterDomain.sdUUID sdUUID = ??? Line 1255: vars.task.getExclusiveLock(STORAGE, "%s_%s" % (vmUUID, sdUUID)) Line 1256: pool.removeVM(vmUUID=vmUUID, sdUUID=sdUUID) Line 1257: Line 1258: @public .................................................... File vdsm/storage/sp.py Line 1629: def _getVMsPath(self, sdUUID): Line 1630: """ Line 1631: Return VMs dir within SD with sdUUID. Line 1632: """ Line 1633: if not self.isActive(sdUUID): Just note that you are now forcing the isActive test on the masterSD which was not the previous logic Line 1634: raise se.StorageDomainNotActive(sdUUID) Line 1635: vmPath = sdCache.produce(sdUUID).getVMsDir() Line 1636: # Get VMs path from the pool (from the master domain) Line 1637: -- To view, visit http://gerrit.ovirt.org/9456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57d9f87a34e1d5659115b09530493824fcda94de Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Paikov <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
