Antoni Segura Puimedon has posted comments on this change.
Change subject: Reduce arguments for addVlan
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/configNetwork.py
Line 457: conf = 'VLAN=yes\n'
Line 458: if bridge:
Line 459: conf += 'BRIDGE=%s\n' % pipes.quote(bridge)
Line 460:
Line 461: self._createConfFile(conf, vlan, mtu, onboot, **kwargs)
I think mtu and onboot should be passed as:
mtu=mtu and onboot=onboot
# usage
self._createConfFile(conf, vlan, mtu, onboot, **kwargs)
# definition
def _createConfFile(self, conf, name, ipaddr=None, netmask=None,
gateway=None, bootproto=None, mtu=None, onboot='yes',
**kwargs)
As you can see, if we were to serve ourselves from just using position, mtu
should be the 7th parameter, cause the third is ipaddr. This will create an
exception.
Line 462:
Line 463: def addBonding(self, bonding, bridge=None, bondingOptions=None,
mtu=None,
Line 464: onboot='yes', **kwargs):
Line 465: """ Create ifcfg-* file with proper fields for bond """
--
To view, visit http://gerrit.ovirt.org/11358
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ee6243ec67e6fa0d070d608f59886dc39cc80b1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
