Dan Kenigsberg has posted comments on this change.
Change subject: tests: Fix race in misc:DdWatchCopy.testStop
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File tests/miscTests.py
Line 507: """
Line 508: try:
Line 509: with tempfile.NamedTemporaryFile() as src:
Line 510: os.unlink(src.name)
Line 511: os.mkfifo(src.name)
what is writing to this fifo? we both no that this unlink/mkfifo pair is
raceful, and that the unlink makes the with-as-src statement a bit pointless.
Maybe reading from /dev/fd/2 would be a bit simpler?
Line 512: with tempfile.NamedTemporaryFile() as dst:
Line 513: ddWatchCopy(src.name, dst.name, lambda: True, 100)
Line 514: except misc.se.ActionStopped:
Line 515: self.log.info("Looks like it stopped!")
--
To view, visit http://gerrit.ovirt.org/11564
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I50e044ec2d949a95e52adcfbc0098a032fb7193d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
