Dan Kenigsberg has posted comments on this change. Change subject: doc: doc generation fix, another attempt. ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) please squash this commit into the former one, and use its Chnage-Id I836210fa5bbd844c20b3b5444be24cd9fa4023e2 That's how you fix a commit in gerrit - we would not want to change a line in one commit only to revert the same line in the following commit. .................................................... File doc/create_sl.sh Line 1: #!/bin/bash Line 2: Line 3: # Adds a symoblic link for vdscli in vdsm if not present. Line 4: VDSCLI=$(readlink -f "../vdsm/vdscli.py") Line 5: if [ ! -e $VDSCLI ] ; then using unquoted variables in bash is usually a bug. Line 6: ln -s ../vdsm_cli/vdscli.py $VDSCLI -- To view, visit http://gerrit.ovirt.org/11661 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76065019f94f332033cb79412e1c1564b5a095fd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
