Igor Lvovsky has posted comments on this change. Change subject: Change getMaxMtu to use the info provided by sysfs ......................................................................
Patch Set 1: (1 inline comment) .................................................... File vdsm/configNetwork.py Line 905: configWriter = ConfigWriter() Line 906: Line 907: prevmtu = None Line 908: if mtu: Line 909: prevmtu = netinfo.getMaxMtu(nics) Ah, Mark sorry it looks like you are right. Indeed we can keep getMaxMtu as a max of existing configuration (in such case 'prevmtu' name is fine) anyway we take mtu=max(prevmtu, mtu) below as you pointed. About the same MTU on NICs of same network, you are right again. Indde the several NICs on same network could co-exist only with bonding, but because we may to use getMaxMtu in some other scenarios I think the better leave it in generic way and pass it devices to check Line 910: Line 911: nic = nics[0] if nics else None Line 912: iface = bonding or nic Line 913: if bridged: -- To view, visit http://gerrit.ovirt.org/11357 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89d007eb81c2c64e642ed80af26f882f7632dc1c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
