Dan Kenigsberg has posted comments on this change. Change subject: jsonrpc: Make reactor clients 1st class objects ......................................................................
Patch Set 5: I would prefer that you didn't submit this It seems that RuntimeError: Set changed size during iteration is a real bug in the unit test - you should first stop the process_requests thread, and only later reactor.stop(). -- To view, visit http://gerrit.ovirt.org/11402 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64e4dfeb4eece4a85a3c6d36324b1e00f366a1cd Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
