Ayal Baron has posted comments on this change. Change subject: Change lvm filter use of regular expression to 'replace \x' ......................................................................
Patch Set 4: Looks good to me, approved Dan's comment is not relevant as whatever names device mapper supports lvm supports, this patch just makes sure that vdsm doesn't ruin the escaping (but Yeela also did extra testing with pipe character etc). -- To view, visit http://gerrit.ovirt.org/11852 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5428d3d8b1d0b10b083b663b12d3a6ceb7e3e69 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Daniel Paikov <pai...@gmail.com> Gerrit-Reviewer: Eduardo <ewars...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
