Dan Kenigsberg has posted comments on this change. Change subject: tests: Avoid ResourceManagerTests failures when running parallel tests ......................................................................
Patch Set 2: I would prefer that you didn't submit this (1 inline comment) .................................................... File tests/resourceManagerTests.py Line 643: def tryThread(fn, *args): Line 644: t = threading.Thread(target=fn, args=args) Line 645: try: Line 646: t.start() Line 647: except: it's only a test, but would you catch only the specific exception that we are expecting here? I hate to falsly skip the test if there's something else happening. Line 648: stop.set() Line 649: while len(resources) > 0: Line 650: res = resources.pop() Line 651: res.release() -- To view, visit http://gerrit.ovirt.org/12034 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd18d683ea3b8f72d569a6151066179ef21d3d26 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <a...@us.ibm.com> Gerrit-Reviewer: Adam Litke <a...@us.ibm.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
