Dan Kenigsberg has posted comments on this change.
Change subject: svdsm: Remove superfluous unlinks
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm/supervdsm.py
Line 114: def _cleanOldFiles(self):
Line 115: self._log.debug("Cleanning svdsm old files: %s, %s",
Line 116: self.pidfile, self.timestamp, self.address)
Line 117: for f in (self.pidfile, self.timestamps):
Line 118: utils.rmFile(str(f))
is the added string-to-string conversion intentional? why?
Line 119:
Line 120: def _start(self):
Line 121: self._authkey = str(uuid.uuid4())
Line 122: self._log.debug("Launching Super Vdsm")
--
To view, visit http://gerrit.ovirt.org/11989
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c3e1968666a34fdfc4b9df8d8c320bcc82c47ca
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
