Federico Simoncelli has posted comments on this change. Change subject: hsm: Check image alignment using virt-alignment-scan ......................................................................
Patch Set 1: (1 inline comment) .................................................... File vdsm/storage/hsm.py Line 1706: spUUID, "mergeSnapshots", pool.mergeSnapshots, sdUUID, vmUUID, Line 1707: imgUUID, ancestor, successor, misc.parseBool(postZero)) Line 1708: Line 1709: @public Line 1710: def getImageAlignment(self, sdUUID, spUUID, imgUUID): I have the feeling that this might be more relevant to clientIF. There are multiple reasons for that. 1) this is not only for images but also to direct luns (and hsm/storage has no saying in that). 2) this could eventually be extended to be executed live (eg. peeking through qemu or the guest-agent). 3) some of the code that we might need (eg: prepareVolumePath vs prepareImage) is in clientIF. 4) since we need to support both images and direct luns we might want to describe the disk in the way we do for the vm creation. Line 1711: """ Line 1712: Returns the alignment of the image Line 1713: Line 1714: :param spUUID: The UUID of the storage pool that contains the image. -- To view, visit http://gerrit.ovirt.org/12003 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia925f5f138948acca623f6379b7b811474a43ffe Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
