Bala.FA has posted comments on this change. Change subject: Added gluster hooks support for existing hooks ......................................................................
Patch Set 12: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/gluster/cli.py Line 1046: raise ge.GlusterHookNotFoundException(gCmd, hookLevel, hookName) Line 1047: try: Line 1048: os.remove(hookFile) Line 1049: except OSError, e: Line 1050: raise ge.GlusterHookRemoveFailedException(err=[str(e)]) As the entire hook functionality is not doing anything with gluster cli, I would think why we can't move this into api.py? -- To view, visit http://gerrit.ovirt.org/9671 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3918aa035d90967f1297dc7fadcf14b6a9385c45 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Timothy Asir <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
