Adam Litke has posted comments on this change.
Change subject: gluster: add task support
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
Some TODO items regarding the schema.
....................................................
File vdsm_api/glusterapi-schema.json
Line 37: # Start rebalance of given volume.
Line 38: #
Line 39: # @volumeName: Gluster volume name
Line 40: #
Line 41: ##
Try running this file through process-schema.py in vdsm_api. That will show
you the places where this schema file is not quite compatible with the expected
format. For example, you have no 'Since' tags. Also, you are missing the
return information for some of these commands.
Line 42: {'command': {'class': 'GlusterVolume', 'name': 'rebalanceStart'},
Line 43: 'data': {'volumeName': 'str'}}
Line 44:
Line 45: ##
--
To view, visit http://gerrit.ovirt.org/10200
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I154df353bc6f23001d7bf61b8f5345abd2019cb6
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barum...@redhat.com>
Gerrit-Reviewer: Adam Litke <a...@us.ibm.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Bala.FA <barum...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeya...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
