Dan Kenigsberg has posted comments on this change.

Change subject: doc: Solved sphinx-build import errors.
......................................................................


Patch Set 4: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File doc/Makefile
Line 2: #
Line 3: 
Line 4: # You can set these variables from the command line.
Line 5: SPHINXOPTS    =
Line 6: SPHINXBUILD   = PYTHONPATH=../vdsm:../$$PYTHONPATH sphinx-build
I do not understand this latest change. could you explain it?
Did you mean

 PYTHONPATH=../vdsm:../:$$PYTHONPATH

? ../$$PYTHON is not going to work well.
Line 7: PAPER         =
Line 8: BUILDDIR      = build
Line 9: 
Line 10: # Internal variables.


--
To view, visit http://gerrit.ovirt.org/11652
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I836210fa5bbd844c20b3b5444be24cd9fa4023e2
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to