Mark Wu has posted comments on this change.
Change subject: vdsm: only specify graphics ports as needed for spice
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/libvirtvm.py
Line 803: <channel type='spicevmc'>
Line 804: <target type='virtio' name='com.redhat.spice.0'/>
Line 805: </channel>
Line 806: """
Line 807: graphicsAttrs = {}
why do you also remove 'autoport'? it looks not required to fix the problem.
And it breaks the test.
Line 808: if self.conf['display'] == 'vnc':
Line 809: graphicsAttrs['type'] = 'vnc'
Line 810: graphicsAttrs['port'] = self.conf['displayPort']
Line 811: elif 'qxl' in self.conf['display']:
--
To view, visit http://gerrit.ovirt.org/12291
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc866259d4cfa95a3b137dce101ce04f215f9f5a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeen...@redhat.com>
Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
