Adam Litke has uploaded a new change for review.

Change subject: api: address and deviceId are optional for VM devices
......................................................................

api: address and deviceId are optional for VM devices

Signed-off-by: Adam Litke <a...@us.ibm.com>
Change-Id: I00fdfd984960e9b71d72e6b455e1aae4e3a7fe49
---
M vdsm_api/vdsmapi-schema.json
1 file changed, 31 insertions(+), 31 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/16/12316/1

diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json
index e2512ea..7e57475 100644
--- a/vdsm_api/vdsmapi-schema.json
+++ b/vdsm_api/vdsmapi-schema.json
@@ -1938,11 +1938,11 @@
 # @propagateErrors:  If enabled, disk I/O errors will be reported to vdsm for
 #                    possible resolution (eg. allocating more space)
 #
-# @address:          Device hardware address
+# @address:          #optional Device hardware address
 #
 # @alias:            Alias used to identify this device in commands
 #
-# @deviceId:         A unique ID for this device
+# @deviceId:         #optional A unique ID for this device
 #
 # @specParams:       #optional Additional device parameters
 #
@@ -1972,8 +1972,8 @@
           'readonly': 'bool', '*bootOrder': 'uint', '*domainID': 'UUID',
           '*poolID': 'UUID', '*imageID': 'UUID', '*volumeID': 'UUID',
           'format': 'VmDiskDeviceFormat', 'propagateErrors': 'bool',
-          'address': 'VmDeviceAddress', 'alias': 'str',
-          'deviceId': 'UUID', '*specParams': 'VmDiskDeviceSpecParams',
+          '*address': 'VmDeviceAddress', 'alias': 'str',
+          '*deviceId': 'UUID', '*specParams': 'VmDiskDeviceSpecParams',
           'apparentsize': 'uint', 'index': 'int', 'name': 'str',
           'optional': 'bool', 'shared': 'bool', 'truesize': 'uint',
           'volumeChain': ['VmDiskDeviceVolumeChainEntry'],
@@ -2046,11 +2046,11 @@
 # @bootOrder:     #optional If specified, this device is part of the boot
 #                 sequence at the specified position
 #
-# @address:       Device hardware address
+# @address:       #optional Device hardware address
 #
 # @alias:         Alias used to identify this device in commands
 #
-# @deviceId:      A unique ID for this device
+# @deviceId:      #optional A unique ID for this device
 #
 # @specParams:    #optional Additional device parameters
 #
@@ -2066,7 +2066,7 @@
  'data': {'deviceType': 'VmDeviceType', 'device': 'VmInterfaceDeviceType',
           'nicModel': 'VmInterfaceDeviceModel', 'macAddr': 'str',
           'network': 'str', '*bootOrder': 'uint',
-          'address': 'VmDeviceAddress', 'alias': 'str', 'deviceId': 'UUID',
+          '*address': 'VmDeviceAddress', 'alias': 'str', '*deviceId': 'UUID',
           '*specParams': 'VmInterfaceDeviceSpecParams', '*linkActive': 'bool',
           '*portMirroring': ['str']}}
 
@@ -2111,11 +2111,11 @@
 #
 # @device:      The type of video device exposed to the VM operating system
 #
-# @address:     Device hardware address
+# @address:     #optional Device hardware address
 #
 # @alias:       Alias used to identify this device in commands
 #
-# @deviceId:    A unique ID for this device
+# @deviceId:    #optional A unique ID for this device
 #
 # @specParams:  #optional Additional device parameters
 #
@@ -2123,7 +2123,7 @@
 ##
 {'type': 'VmVideoDevice',
  'data': {'deviceType': 'VmDeviceType', 'device': 'VmVideoDeviceType',
-          'address': 'VmDeviceAddress', 'alias': 'str', 'deviceId': 'UUID',
+          '*address': 'VmDeviceAddress', 'alias': 'str', '*deviceId': 'UUID',
           '*specParams': 'VmVideoDeviceSpecParams'}}
 
 ##
@@ -2166,11 +2166,11 @@
 #
 # @device:      The type of sound hardware exposed to the VM operating system
 #
-# @address:     Device hardware address
+# @address:     #optional Device hardware address
 #
 # @alias:       Alias used to identify this device in commands
 #
-# @deviceId:    A unique ID for this device
+# @deviceId:    #optional A unique ID for this device
 #
 # @specParams:  #optional Additional device parameters
 #
@@ -2178,7 +2178,7 @@
 ##
 {'type': 'VmSoundDevice',
  'data': {'deviceType': 'VmDeviceType', 'device': 'VmSoundDeviceType',
-          'address': 'VmDeviceAddress', 'alias': 'str', 'deviceId': 'UUID',
+          '*address': 'VmDeviceAddress', 'alias': 'str', '*deviceId': 'UUID',
           '*specParams': 'VmSoundDeviceSpecParams'}}
 
 ##
@@ -2214,17 +2214,17 @@
 #
 # @device:      The specific type of controller device
 #
-# @address:     Device hardware address
+# @address:     #optional Device hardware address
 #
 # @alias:       Alias used to identify this device in commands
 #
-# @deviceId:    A unique ID for this device
+# @deviceId:    #optional A unique ID for this device
 #
 # Since: 4.10.0
 ##
 {'type': 'VmControllerDevice',
  'data': {'deviceType': 'VmDeviceType', 'device': 'VmControllerDeviceType',
-          'address': 'VmDeviceAddress', 'alias': 'str', 'deviceId': 'UUID'}}
+          '*address': 'VmDeviceAddress', 'alias': 'str', '*deviceId': 'UUID'}}
 
 ##
 # @VmBalloonDeviceType:
@@ -2271,20 +2271,20 @@
 #
 # @device:      The the type of balloon device
 #
-# @address:     Device hardware address
+# @address:     #optional Device hardware address
 #
 # @alias:       Alias used to identify this device in commands
 #
 # @specParams:  #optional Additional device parameters
 #
-# @deviceId:    A unique ID for this device
+# @deviceId:    #optional A unique ID for this device
 #
 # Since: 4.10.0
 ##
 {'type': 'VmBalloonDevice',
  'data': {'deviceType': 'VmDeviceType', 'device': 'VmBalloonDeviceType',
-          'address': 'VmDeviceAddress', 'alias': 'str',
-          '*specParams': 'VmBalloonDeviceSpecParams', 'deviceId': 'UUID'}}
+          '*address': 'VmDeviceAddress', 'alias': 'str',
+          '*specParams': 'VmBalloonDeviceSpecParams', '*deviceId': 'UUID'}}
 
 ##
 # @VmWatchdogDeviceType:
@@ -2355,20 +2355,20 @@
 #
 # @device:      The the type of watchdog device
 #
-# @address:     Device hardware address, only 'i6300esb' need address
+# @address:     #optional Device hardware address, only 'i6300esb' need address
 #
 # @alias:       Alias used to identify this device in commands
 #
 # @specParams:  #optional Additional device parameters
 #
-# @deviceId:    A unique ID for this device
+# @deviceId:    #optional A unique ID for this device
 #
 # Since: 4.10.1
 ##
 {'type': 'VmWatchdogDevice',
  'data': {'deviceType': 'VmDeviceType', 'device': 'VmWatchdogDeviceType',
-          'address': 'VmDeviceAddress', 'alias': 'str',
-          '*specParams': 'VmWatchdogDeviceSpecParams', 'deviceId': 'UUID'}}
+          '*address': 'VmDeviceAddress', 'alias': 'str',
+          '*specParams': 'VmWatchdogDeviceSpecParams', '*deviceId': 'UUID'}}
 
 ##
 # @VmChannelDeviceType:
@@ -2394,17 +2394,17 @@
 #
 # @device:      The specific type of channel device
 #
-# @address:     Device hardware address
+# @address:     #optional Device hardware address
 #
 # @alias:       Alias used to identify this device in commands
 #
-# @deviceId:    A unique ID for this device
+# @deviceId:    #optional A unique ID for this device
 #
 # Since: 4.10.0
 ##
 {'type': 'VmChannelDevice',
  'data': {'deviceType': 'VmDeviceType', 'device': 'VmChannelDeviceType',
-          'address': 'VmDeviceAddress', 'alias': 'str', 'deviceId': 'UUID'}}
+          '*address': 'VmDeviceAddress', 'alias': 'str', '*deviceId': 'UUID'}}
 
 ##
 # @VmSmartcardDeviceSpecParams:
@@ -2435,7 +2435,7 @@
 #
 # @device:      The the type of smartcard device
 #
-# @address:     Device hardware address
+# @address:     #optional Device hardware address
 #
 # @alias:       Alias used to identify this device in commands
 #
@@ -2445,7 +2445,7 @@
 ##
 {'type': 'VmSmartcardDevice',
  'data': {'deviceType': 'VmDeviceType', 'device': 'VmSmartcardDeviceType',
-          'address': 'VmDeviceAddress', 'alias': 'str',
+          '*address': 'VmDeviceAddress', 'alias': 'str',
           '*specParams': 'VmSmartcardDeviceSpecParams'}}
 
 ##
@@ -2455,12 +2455,12 @@
 #
 # @deviceType:  The device type (always @console)
 #
-# @deviceId:    A unique ID for this device
+# @deviceId:    #optional A unique ID for this device
 #
 # Since: 4.10.0
 ##
 {'type': 'VmConsoleDevice',
- 'data': {'deviceType': 'VmDeviceType', 'deviceId': 'UUID'}}
+ 'data': {'deviceType': 'VmDeviceType', '*deviceId': 'UUID'}}
 
 ##
 # @VmDevice:


--
To view, visit http://gerrit.ovirt.org/12316
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I00fdfd984960e9b71d72e6b455e1aae4e3a7fe49
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <a...@us.ibm.com>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to