Yaniv Bronhaim has posted comments on this change.
Change subject: Adding constant for log file permissions
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/vdsm-logrotate.conf.in
Line 5: compress
Line 6: compresscmd /usr/bin/xz
Line 7: uncompresscmd /usr/bin/unxz
Line 8: compressext .xz
Line 9: create @VDSMLOGPERM@ @VDSMUSER@ @VDSMGROUP@
If we want to modify the log file permission it can be configured for user vdsm
umask. Currently the umask is 0022 means each created file by vdsm will get
644. It's default for new user in rhel. I don't think its on purpose, and I
thought it might be more reasonable to create the log with 600, so only root
and vdsm user will be able to read it.. but I might should raise it up before
changing it
Line 10: }
Line 11: /var/log/core/*.dump {
Line 12: rotate 1
Line 13: missingok
--
To view, visit http://gerrit.ovirt.org/12380
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa362d47f5d1b5d7fbc1c3ab96c3381aefefd6f3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
