Mark Wu has posted comments on this change.
Change subject: tc: set/unset promisc when it's really needed
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
but it could be cooler.
....................................................
File vdsm/tc.py
Line 182: if bool(flags & ethtool.IFF_PROMISC) != on:
Line 183: if on:
Line 184: flags |= ethtool.IFF_PROMISC
Line 185: else:
Line 186: flags &= ~ethtool.IFF_PROMISC
is it better?
if bool(flags & ethtool.IFF_PROMISC) != on:
flags ^= ethtool.IFF_PROMISC
Line 187:
Line 188: set_flags(dev, flags)
Line 189:
Line 190:
--
To view, visit http://gerrit.ovirt.org/12307
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d38e2f13a059ea916892ab8247509e2e0b612e2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Hunt Xu <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Hunt Xu <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
