Eduardo has uploaded a new change for review.

Change subject: Ignore postZero flag when deleting an image on a fileSD.
......................................................................

Ignore postZero flag when deleting an image on a fileSD.

Ignoring parameters is very bad but we will continue to do that
because fixing the engine is very hard until the day of a real
fix.

Bug-url: https://bugzilla.redhat.com/show_bug.cgi?id=911209

Change-Id: Ief50d6174fd20e16f2fdf48a6cd512d20b9f407d
Signed-off-by: Eduardo <[email protected]>
---
M vdsm/storage/fileSD.py
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/04/12404/1

diff --git a/vdsm/storage/fileSD.py b/vdsm/storage/fileSD.py
index fa837fc..12d90f7 100644
--- a/vdsm/storage/fileSD.py
+++ b/vdsm/storage/fileSD.py
@@ -364,9 +364,9 @@
             raise se.ImageDeleteError("%s %s" % (imgUUID, str(e)))
 
     def zeroImage(self, sdUUID, imgUUID, volsImgs):
-        raise se.SourceImageActionError(
-            imgUUID, sdUUID, "image %s on a fileSD %s should not be zeroed." %
-            (imgUUID, sdUUID))
+        self.log.warning(imgUUID, sdUUID, "image %s on a fileSD %s will be "
+                         "not zeroed." % (imgUUID, sdUUID))
+        self.deleteImage(sdUUID, imgUUID, volsImgs)
 
     def getAllVolumes(self):
         """


--
To view, visit http://gerrit.ovirt.org/12404
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ief50d6174fd20e16f2fdf48a6cd512d20b9f407d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to