Dan Kenigsberg has posted comments on this change. Change subject: Use absolute path of multipath.conf file ......................................................................
Patch Set 2: (2 inline comments) .................................................... File vdsm/sudoers.vdsm.in Line 34: @PERSIST_PATH@ /etc/multipath.conf, \ Line 35: @PERSIST_PATH@ /var/log/vdsm/backup/*, \ Line 36: @UNPERSIST_PATH@ /etc/multipath.conf, \ Line 37: @UNPERSIST_PATH@ /var/log/vdsm/backup/*, \ Line 38: @CP_PATH@ * /etc/multipath.conf *, \ I'm not sure we should keep this line - it looks like CP with 3 args, which is ugly and misleading, and allows putting funny flags. Line 39: @CP_PATH@ * /var/log/vdsm/backup/* *, \ Line 40: @MULTIPATH_PATH@, \ Line 41: @MULTIPATH_PATH@ -F, \ Line 42: @BLOCKDEV_PATH@ --getsize64 *, \ Line 35: @PERSIST_PATH@ /var/log/vdsm/backup/*, \ Line 36: @UNPERSIST_PATH@ /etc/multipath.conf, \ Line 37: @UNPERSIST_PATH@ /var/log/vdsm/backup/*, \ Line 38: @CP_PATH@ * /etc/multipath.conf *, \ Line 39: @CP_PATH@ * /var/log/vdsm/backup/* *, \ you may postpone this to a following patch. But I do not think that this entry is ever used by vdsm. Line 40: @MULTIPATH_PATH@, \ Line 41: @MULTIPATH_PATH@ -F, \ Line 42: @BLOCKDEV_PATH@ --getsize64 *, \ Line 43: @SETSID_PATH@ @IONICE_PATH@ -c ? -n ? @SU_PATH@ vdsm -s /bin/sh -c /usr/libexec/vdsm/spmprotect.sh*, \ -- To view, visit http://gerrit.ovirt.org/12226 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie732400423f12b0a783bd251b4e2cc2e2409ffec Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pavel Zhukov <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Pavel Zhukov <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
