Dan Kenigsberg has posted comments on this change.
Change subject: Catch libvirt timeout and return an error on setVmTicket
......................................................................
Patch Set 9: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/libvirtvm.py
Line 2413: hooks.before_vm_set_ticket(self._lastXMLDesc, self.conf,
params)
Line 2414: try:
Line 2415: self._dom.updateDeviceFlags(graphics.toxml(), 0)
Line 2416: except TimeoutError as tmo:
Line 2417: result = dict(errCode['ticketErr'])
Oops! I did not notice our over-writing on errCode['ticketErr']. but since
dict() does only a shallow copy, your solution is not enough.
I see no immediate choice but the likes of
return {'status': {'code': errCode['hotplugNic']['status']['code'],
'message': e.message}}
Line 2418: result['status']['message'] = unicode(tmo)
Line 2419: else:
Line 2420: hooks.after_vm_set_ticket(self._lastXMLDesc, self.conf,
params)
Line 2421: result = {'status': doneCode}
--
To view, visit http://gerrit.ovirt.org/10285
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb48a1baff1e059f48f71f600f4bf5d9f40a7d11
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
