Zhou Zheng Sheng has uploaded a new change for review. Change subject: Fix Fedora 18 pyflakes warning for lvm.py ......................................................................
Fix Fedora 18 pyflakes warning for lvm.py a local variable 'lv' is shadowed in a list comprehension. Recent pyflakes can detect this case can report error. This patch rename the temp variable in the list comprehension to avoid shadowing the local variable. Change-Id: Ifb7d7285a8045748f02fb9096d8622888892d8d0 Signed-off-by: Zhou Zheng Sheng <[email protected]> --- M vdsm/storage/lvm.py 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/92/12592/1 diff --git a/vdsm/storage/lvm.py b/vdsm/storage/lvm.py index 97fe38a..e3a73fa 100644 --- a/vdsm/storage/lvm.py +++ b/vdsm/storage/lvm.py @@ -605,8 +605,9 @@ else: lvs = dict(self._lvs) # lvs = self._reloadlvs() - lvs = [lv for lv in lvs.values() - if not isinstance(lv, Stub) and (lv.vg_name == vgName)] + lvs = [tmpLv for tmpLv in lvs.values() + if not isinstance(tmpLv, Stub) and + (tmpLv.vg_name == vgName)] res = lvs return res -- To view, visit http://gerrit.ovirt.org/12592 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifb7d7285a8045748f02fb9096d8622888892d8d0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
